On Thu Aug 7, 2025 at 6:43 PM CEST, Himal Prasad Ghimiray wrote:
> From: Boris Brezillon <boris.brezil...@collabora.com>
>
> We are about to pass more arguments to drm_gpuvm_sm_map[_ops_create](),
> so, before we do that, let's pass arguments through a struct instead
> of changing each call site every time a new optional argument is added.
>
> v5
> - Use drm_gpuva_op_map—same as drm_gpuvm_map_req
> - Rebase changes for drm_gpuvm_sm_map_exec_lock()
> - Fix kernel-docs
>
> v6
> - Use drm_gpuvm_map_req (Danilo/Matt)
>
> Cc: Danilo Krummrich <d...@kernel.org>
> Cc: Brendan King <brendan.k...@imgtec.com>
> Cc: Boris Brezillon <bbrezil...@kernel.org>
> Cc: Caterina Shablia <caterina.shab...@collabora.com>
> Cc: Rob Clark <robin.cl...@oss.qualcomm.com>
> Cc: Matthew Brost <matthew.br...@intel.com>
> Cc: <dri-devel@lists.freedesktop.org>
> Signed-off-by: Boris Brezillon <boris.brezil...@collabora.com>
> Signed-off-by: Caterina Shablia <caterina.shab...@collabora.com>
Caterina does not seem to be involved in handling this patch. Either you should
remove this SoB or adda Co-developed-by: tag for her if that's the case.
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimi...@intel.com>
You may also want to add a Co-developed-by: tag for yourself given that you made
significant changes to the patch. But that's between Boris and you of course.
> +/**
> + * struct drm_gpuvm_map_req - arguments passed to
> drm_gpuvm_sm_map[_ops_create]()
> + */
> +struct drm_gpuvm_map_req {
> + /**
> + * @op_map: struct drm_gpuva_op_map
> + */
> + struct drm_gpuva_op_map op_map;
I think this should just be 'op', the outer structure says 'map' already.
> +};
