On 08/06/2025, Shengjiu Wang wrote: > On Tue, Aug 5, 2025 at 4:55 PM Liu Ying <victor....@nxp.com> wrote: >> >> On 08/04/2025, Shengjiu Wang wrote:
[...] >>> +#define HTX_PAI_STAT 0x0c >>> +#define HTX_PAI_IRQ_NOMASK 0x10 >>> +#define HTX_PAI_IRQ_MASKED 0x14 >>> +#define HTX_PAI_IRQ_MASK 0x18 >> >> The above 4 registers are not pratically used. Drop. > > They are used by regmap to make a full definition. Yes, but they are not pratically used for interrupt support. Once you add interrupt support in this driver, you may add these registers. [...] >>> + /* PCM choose 24bit*/ >>> + val = FIELD_PREP(D_SEL, width - 24); >> >> Why 'width - 24'? Can it be expressed by a helper or macro? > > /* > * The allowed width are 24bit and 32bit, as they are > supported by > * aud2htx module. > * for 24bit, D_SEL = 0, select all the bits. > * for 32bit, D_SEL = 8, select the MSB. > */ > will add such comments. Fine for me(Not an audio guy though). -- Regards, Liu Ying
