On Fri Aug 1, 2025 at 4:50 PM CEST, Timur Tabi wrote:
> Does mean that the TODO has been done, or that someone completely forgot and
> now your patch is
> remove all reminders?
>
> If it's the format, maybe add a fixes: tag for the commit that resolved the
> TODO?
The TODO was introduced by commit ebb945a94bba ("drm/nouveau: port all engines
to new engine module format") from 2012.
It's a bit hard to know what exactly resolves "this will be reworked in the near
future" for a commit with the following diffstat. :)
146 files changed, 14219 insertions(+), 11099 deletions(-)
The last remains of accel_done were removed with commit
4e2ec2500bfc ("drm/nouveau: Remove file nouveau_fbcon.c"), but I don't think we
should mention this commit, given that apparently no one knows what was intended
to be reworked here [1].
We could mention the above in the commit message, though it will also be
available through the lore link in the commit message once the patch is applied.
NIT: Please don't top post, use interleaved style [2] instead.
[1]
https://lore.kernel.org/all/481a2808c235f95726d17803503b2b6dc2746dc3.ca...@mailbox.org/
[2]
https://docs.kernel.org/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions
