Re: [PATCH v3 28/54] dyndbg: restore classmap protection when theres a controlling_param

[jim . cromie]

On Fri, Jun 20, 2025 at 8:47 AM Sean Paul <seanp...@chromium.org> wrote:

> On Thu, Apr 3, 2025 at 9:48 AM Jim Cromie <jim.cro...@gmail.com> wrote:
> >
>
> \snip
>
> >
> > -static void ddebug_match_apply_kparam(const struct kernel_param *kp,
> > -                                     const struct _ddebug_class_map
> *map,
> > -                                     const char *mod_name)
> > +static struct _ddebug_class_param *
> > +ddebug_get_classmap_kparam(const struct kernel_param *kp,
> > +                          const struct _ddebug_class_map *map)
> >  {
> >         struct _ddebug_class_param *dcp;
> >
> >         if (kp->ops != &param_ops_dyndbg_classes)
> > -               return;
> > +               return false;
>
> Return type is struct _ddebug_class_param *, should this be NULL?
>
>
yes it should. thx.  will revise

>
>