On Sat Jul 19, 2025 at 5:23 AM JST, John Hubbard wrote:
> On 7/18/25 12:26 AM, Alexandre Courbot wrote:
> ...
>> diff --git a/drivers/gpu/nova-core/falcon/gsp.rs
>> b/drivers/gpu/nova-core/falcon/gsp.rs
>> index
>> 0db9f94036a6a7ced5a461aec2cff2ce246a5e0e..f17599cb49fa1e5077a554dc14b3715aa62a4ebd
>> 100644
>> --- a/drivers/gpu/nova-core/falcon/gsp.rs
>> +++ b/drivers/gpu/nova-core/falcon/gsp.rs
>> @@ -2,7 +2,7 @@
>>
>> use crate::{
>> driver::Bar0,
>> - falcon::{Falcon, FalconEngine, PFalconBase},
>> + falcon::{Falcon, FalconEngine, PFalcon2Base, PFalconBase},
>> regs::{self, macros::RegisterBase},
>> };
>>
>> @@ -13,6 +13,10 @@ impl RegisterBase<PFalconBase> for Gsp {
>> const BASE: usize = 0x00110000;
>
> This approach means that the reference manual values such as these, end
> up being scattered throughout the code base, as magic numbers.
>
> I'm thinking that there should be no problem with using a symbol from
> the manuals, listed in a common area, instead, right?
Correct, there should be nothing preventing us from doing that if we
think it is a better way to organize these (which I agree it probably
is).
