Re: [PATCH v3 1/5] dt-bindings: Fixup x1e80100 to add DP MST support

[Jessica Zhang]

On 7/18/2025 2:13 AM, Dmitry Baryshkov wrote:
On Thu, Jul 17, 2025 at 04:28:43PM -0700, Jessica Zhang wrote:
From: Abhinav Kumar <quic_abhin...@quicinc.com>

Please fix the patch subject.

Hi Dmitry,

Ack.



Add x1e80100 to the dp-controller bindings, fix the
displayport-controller reg bindings, and drop
assigned-clock-parents/assigned-clocks

Why?

IIRC issues with the x1e80100 dp-controller bindings (i.e. the reg 
bindings) weren't being picked up by dtschema because the x1e80100-dp 
compatible string wasn't in dp-controller.yaml.

I can add this to the commit msg after moving the 
assigned-clocks/clock-parents change to patch 3.



Signed-off-by: Abhinav Kumar <quic_abhin...@quicinc.com>
Reviewed-by: "Rob Herring (Arm)" <r...@kernel.org>
Signed-off-by: Jessica Zhang <jessica.zh...@oss.qualcomm.com>
---
  .../devicetree/bindings/display/msm/dp-controller.yaml    |  2 ++
  .../bindings/display/msm/qcom,x1e80100-mdss.yaml          | 15 +++++----------

Split into two commits.

Would it be better if I kept the compatible/reg bindings fix in this 
commit then squashed the assigned-clocks/clock-parents change with patch 3?

Thanks,

Jessica Zhang


  2 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml 
b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index 9923b065323b..4676aa8db2f4 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -29,6 +29,8 @@ properties:
            - qcom,sdm845-dp
            - qcom,sm8350-dp
            - qcom,sm8650-dp
+          - qcom,x1e80100-dp
+
        - items:
            - enum:
                - qcom,sar2130p-dp
diff --git 
a/Documentation/devicetree/bindings/display/msm/qcom,x1e80100-mdss.yaml 
b/Documentation/devicetree/bindings/display/msm/qcom,x1e80100-mdss.yaml
index 3b01a0e47333..0e699de684c8 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,x1e80100-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,x1e80100-mdss.yaml
@@ -170,11 +170,11 @@ examples:
  
          displayport-controller@ae90000 {
              compatible = "qcom,x1e80100-dp";
-            reg = <0 0xae90000 0 0x200>,
-                  <0 0xae90200 0 0x200>,
-                  <0 0xae90400 0 0x600>,
-                  <0 0xae91000 0 0x400>,
-                  <0 0xae91400 0 0x400>;
+            reg = <0xae90000 0x200>,
+                  <0xae90200 0x200>,
+                  <0xae90400 0x600>,
+                  <0xae91000 0x400>,
+                  <0xae91400 0x400>;
  
              interrupt-parent = <&mdss>;
              interrupts = <12>;
@@ -189,11 +189,6 @@ examples:
                      "ctrl_link_iface",
                      "stream_pixel";
  
-            assigned-clocks = <&dispcc_mdss_dptx0_link_clk_src>,
-                  <&dispcc_mdss_dptx0_pixel0_clk_src>;
-            assigned-clock-parents = <&usb_1_ss0_qmpphy 
QMP_USB43DP_DP_LINK_CLK>,
-                  <&usb_1_ss0_qmpphy QMP_USB43DP_DP_VCO_DIV_CLK>;
-
              operating-points-v2 = <&mdss_dp0_opp_table>;
  
              power-domains = <&rpmhpd RPMHPD_MMCX>;

--
2.50.1