Re: [PATCH] drm/amdgpu: check if hubbub is NULL in debugfs/amdgpu_dm_capabilities

[Alex Deucher]

Applied.  Thanks!

Alex

On Thu, Jul 17, 2025 at 4:58 PM Peter Shkenev <mustela@erminea.space> wrote:
>
> HUBBUB structure is not initialized on DCE hardware, so check if it is NULL
> to avoid null dereference while accessing amdgpu_dm_capabilities file in
> debugfs.
>
> Signed-off-by: Peter Shkenev <mustela@erminea.space>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c 
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> index c7d13e743e6c..b726bcd18e29 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> @@ -3988,7 +3988,7 @@ static int capabilities_show(struct seq_file *m, void 
> *unused)
>
>         struct hubbub *hubbub = dc->res_pool->hubbub;
>
> -       if (hubbub->funcs->get_mall_en)
> +       if (hubbub && hubbub->funcs->get_mall_en)
>                 hubbub->funcs->get_mall_en(hubbub, &mall_in_use);
>
>         if (dc->cap_funcs.get_subvp_en)
> --
> 2.50.1
>