> > diff --git a/drivers/virtio/virtio_dma_buf.c > > b/drivers/virtio/virtio_dma_buf.c > > index 3fe1d03b0645..986cc73c503f 100644 > > --- a/drivers/virtio/virtio_dma_buf.c > > +++ b/drivers/virtio/virtio_dma_buf.c > > @@ -16,6 +16,8 @@ > > * This wraps dma_buf_export() to allow virtio drivers to create a dma-buf > > * for an virtio exported object that can be queried by other virtio > > drivers > > * for the object's UUID. > > + * > > + * Returns: dma-buf pointer on success, ERR_PTR on failure. > > Most people write "dmabuf".
Thanks for pointing this out. In virtio_dma_buf.c specifically, "dma-buf" appears more frequently throughout the file. For consistency within this file, I'll keep using "dma-buf" in these docs. > > */ > > struct dma_buf *virtio_dma_buf_export > > (const struct dma_buf_export_info *exp_info) > > @@ -36,6 +38,14 @@ EXPORT_SYMBOL(virtio_dma_buf_export); > > > > /** > > * virtio_dma_buf_attach - mandatory attach callback for virtio dma-bufs > > + * @dma_buf: DMA buffer being attached to a device > > And here it's different for some reason. > > > + * @attach: Attachment metadata for the device-dma_buf association > > and here in a third form. Thanks for catching the inconsistency. Here are the standardized parameter descriptions: @dma_buf: dma-buf being attached to a device @attach: Attachment metadata for the dma-buf association > > + * > > + * Allows virtio devices to perform device-specific setup when a DMA buffer > > + * is attached to a device. This is part of the DMA-BUF sharing mechanism > > + * that enables virtio devices to interoperate with other subsystems. > > I'm sorry this is just empty of content. > I can not shake the feeling this is AI written. > If we wanted AI to document all APIs in this way, I'd just script it. I‘ll remove the generic description. Best regards, Peng Jiang
