----- Original Message ----- > From: "Konrad Rzeszutek Wilk" <konrad.wilk at oracle.com> > To: "Jerome Glisse" <j.glisse at gmail.com> > Cc: dri-devel at lists.freedesktop.org, "Jerome Glisse" <jglisse at > redhat.com>, kernel-janitors at vger.kernel.org, "Thomas > Hellstrom" <thellstrom at vmware.com>, "Dan Carpenter" <dan.carpenter at > oracle.com> > Sent: Thursday, 8 December, 2011 4:53:34 PM > Subject: Re: [patch] drm/ttm: fix condition (and vs or) > > On Thu, Dec 08, 2011 at 10:34:00AM -0500, Jerome Glisse wrote: > > On Thu, Dec 08, 2011 at 09:50:54AM +0300, Dan Carpenter wrote: > > > The "if (!p && !p->dev)" condition isn't right because || was > > > intended > > > instead of &&. But actually, "p" is the list cursor and so it's > > > always > > Duh! > > > non-NULL and we can just remove that bit. We can remove the > > > another > > > similar check as well. > > > > > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > > Reviewed-by: Jerome Glisse <jglisse at redhat.com> > > And Acked-by me. > > Jerome, since you have the patches (And are thinking to send a GIT > PULL > to Dave) in your tree, could you include this patch in your queue? >
I've taken the TTM changes into drm-next already, just reviewing the radeon stuff. But if that appeared on top in Jerome's tree I can steal it. Dave.
