The prefix as_* should not be used for a constructor. Constructors usually use the prefix from_* instead.
Some prior art in the stdlib: Box::from_raw, CString::from_raw, Rc::from_raw, Arc::from_raw, Waker::from_raw, File::from_raw_fd. There is also prior art in the kernel crate: cpufreq::Policy::from_raw, fs::File::from_raw_file, Kuid::from_raw, ARef::from_raw, SeqFile::from_raw, VmaNew::from_raw, Io::from_raw. For more, see: https://lore.kernel.org/r/aCd8D5IA0RXZvtcv@pollux Signed-off-by: Alice Ryhl <alicer...@google.com> --- Changes in v2: - Split into two patches. - Use a different lore link. - Link to v1: https://lore.kernel.org/r/20250709-device-as-ref-v1-1-ebf7059ff...@google.com --- Alice Ryhl (2): device: rust: rename Device::as_ref() to Device::from_raw() drm: rust: rename as_ref() to from_raw() for drm constructors rust/kernel/auxiliary.rs | 2 +- rust/kernel/cpu.rs | 2 +- rust/kernel/device.rs | 6 +++--- rust/kernel/drm/device.rs | 4 ++-- rust/kernel/drm/file.rs | 8 ++++---- rust/kernel/drm/gem/mod.rs | 16 ++++++++-------- rust/kernel/drm/ioctl.rs | 4 ++-- rust/kernel/faux.rs | 2 +- rust/kernel/miscdevice.rs | 2 +- rust/kernel/net/phy.rs | 2 +- rust/kernel/pci.rs | 2 +- rust/kernel/platform.rs | 2 +- 12 files changed, 26 insertions(+), 26 deletions(-) --- base-commit: 86731a2a651e58953fc949573895f2fa6d456841 change-id: 20250709-device-as-ref-350db5317dd1 Best regards, -- Alice Ryhl <alicer...@google.com>
