On 10/07/2025 20:53, Williams, Gregory wrote: >> >> >>> 1 file changed, 55 insertions(+) >>> create mode 100644 include/dt-bindings/power/xlnx-versal-power.h >>> >>> diff --git a/include/dt-bindings/power/xlnx-versal-power.h >>> b/include/dt-bindings/power/xlnx-versal-power.h >>> new file mode 100644 >>> index 000000000000..effbc70e5a12 >>> --- /dev/null >>> +++ b/include/dt-bindings/power/xlnx-versal-power.h >>> @@ -0,0 +1,55 @@ >>> +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) */ >>> +/* >>> + * Copyright (C) 2019 - 2021 Xilinx, Inc. >>> + * Copyright (C) 2024 Advanced Micro Devices, Inc. >>> + */ >>> + >>> +#ifndef _DT_BINDINGS_VERSAL_POWER_H >>> +#define _DT_BINDINGS_VERSAL_POWER_H >>> + >>> +#define PM_DEV_RPU0_0 (0x18110005U) >>> +#define PM_DEV_RPU0_1 (0x18110006U) >> >> Bindings ID start from 0 or 1 and are decimal numbers. None of these are >> bindings (and commit msg does not explain here anything). >> >> Also, where is the compatible using these? Why is this a separate patch? > In 'Submitting DT binding patches' it says: "The Documentation/ and > include/dt-bindings/ portion of the patch should be a separate patch".
Separate from the driver. But that's a single patch. Best regards, Krzysztof
