The test works even without it, but lockdep starts screaming when it is
activated.

Trivially fix it by acquiring the lock before we try to allocate
something.

Signed-off-by: Christian König <christian.koe...@amd.com>
---
 drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c 
b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c
index 3148f5d3dbd6..38f476787302 100644
--- a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c
+++ b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c
@@ -542,14 +542,15 @@ static void ttm_bo_validate_no_placement_signaled(struct 
kunit *test)
                bo->ttm = old_tt;
        }
 
-       err = ttm_resource_alloc(bo, place, &bo->resource, NULL);
-       KUNIT_EXPECT_EQ(test, err, 0);
-       KUNIT_ASSERT_EQ(test, man->usage, size);
-
        placement = kunit_kzalloc(test, sizeof(*placement), GFP_KERNEL);
        KUNIT_ASSERT_NOT_NULL(test, placement);
 
        ttm_bo_reserve(bo, false, false, NULL);
+
+       err = ttm_resource_alloc(bo, place, &bo->resource, NULL);
+       KUNIT_EXPECT_EQ(test, err, 0);
+       KUNIT_ASSERT_EQ(test, man->usage, size);
+
        err = ttm_bo_validate(bo, placement, &ctx);
        ttm_bo_unreserve(bo);
 
-- 
2.34.1

Reply via email to