Re: [PATCH 02/80] accel/amdxdna: Remove redundant pm_runtime_mark_last_busy() calls

[Lizhi Hou]

Reviewed-by: Lizhi Hou <lizhi....@amd.com>

On 7/4/25 00:53, Sakari Ailus wrote:

pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
pm_runtime_mark_last_busy().

Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
---
The cover letter of the set can be found here
<URL:https://lore.kernel.org/linux-pm/20250704075225.3212486-1-sakari.ai...@linux.intel.com>.

In brief, this patch depends on PM runtime patches adding marking the last
busy timestamp in autosuspend related functions. The patches are here, on
rc2:

         git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \
                 pm-runtime-6.17-rc1

  drivers/accel/amdxdna/amdxdna_pci_drv.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/drivers/accel/amdxdna/amdxdna_pci_drv.c 
b/drivers/accel/amdxdna/amdxdna_pci_drv.c
index f2bf1d374cc7..c7083a657333 100644
--- a/drivers/accel/amdxdna/amdxdna_pci_drv.c
+++ b/drivers/accel/amdxdna/amdxdna_pci_drv.c
@@ -101,7 +101,6 @@ static int amdxdna_drm_open(struct drm_device *ddev, struct 
drm_file *filp)
  failed:
        kfree(client);
  put_rpm:
-       pm_runtime_mark_last_busy(ddev->dev);
        pm_runtime_put_autosuspend(ddev->dev);

return ret;

@@ -125,7 +124,6 @@ static void amdxdna_drm_close(struct drm_device *ddev, 
struct drm_file *filp)

XDNA_DBG(xdna, "pid %d closed", client->pid);

        kfree(client);
-       pm_runtime_mark_last_busy(ddev->dev);
        pm_runtime_put_autosuspend(ddev->dev);
  }

@@ -296,7 +294,6 @@ static int amdxdna_probe(struct pci_dev *pdev, const struct pci_device_id *id)

                goto failed_sysfs_fini;
        }

- pm_runtime_mark_last_busy(dev);

        pm_runtime_put_autosuspend(dev);
        return 0;