On Tue, Jul 01, 2025 at 10:18:01PM +0300, Laurent Pinchart wrote:
> Hi Ville,
>
> Thank you for the patch.
>
> On Tue, Jul 01, 2025 at 12:07:07PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrj...@linux.intel.com>
> >
> > Pass along the format information from the top to .fb_create()
> > so that we can avoid redundant (and somewhat expensive) lookups
> > in the drivers.
> >
> > Done with cocci (with some manual fixups):
> > @@
> > identifier func =~ ".*create.*";
> > identifier dev, file, mode_cmd;
> > @@
> > struct drm_framebuffer *func(
> > struct drm_device *dev,
> > struct drm_file *file,
> > + const struct drm_format_info *info,
> > const struct drm_mode_fb_cmd2 *mode_cmd)
> > {
> > ...
> > (
> > - const struct drm_format_info *info = drm_get_format_info(...);
> > |
> > - const struct drm_format_info *info;
> > ...
> > - info = drm_get_format_info(...);
> > )
> > <...
> > - if (!info)
> > - return ...;
> > ...>
> > }
> >
> > @@
> > identifier func =~ ".*create.*";
> > identifier dev, file, mode_cmd;
> > @@
> > struct drm_framebuffer *func(
> > struct drm_device *dev,
> > struct drm_file *file,
> > + const struct drm_format_info *info,
> > const struct drm_mode_fb_cmd2 *mode_cmd)
> > {
> > ...
> > }
> >
> > @find@
> > identifier fb_create_func =~ ".*create.*";
> > identifier dev, file, mode_cmd;
> > @@
> > struct drm_framebuffer *fb_create_func(
> > struct drm_device *dev,
> > struct drm_file *file,
> > + const struct drm_format_info *info,
> > const struct drm_mode_fb_cmd2 *mode_cmd);
> >
> > @@
> > identifier find.fb_create_func;
> > expression dev, file, mode_cmd;
> > @@
> > fb_create_func(dev, file
> > + ,info
> > ,mode_cmd)
> >
> > @@
> > expression dev, file, mode_cmd;
> > @@
> > drm_gem_fb_create(dev, file
> > + ,info
> > ,mode_cmd)
> >
> > @@
> > expression dev, file, mode_cmd;
> > @@
> > drm_gem_fb_create_with_dirty(dev, file
> > + ,info
> > ,mode_cmd)
> >
> > @@
> > expression dev, file_priv, mode_cmd;
> > identifier info, fb;
> > @@
> > info = drm_get_format_info(...);
> > ...
> > fb = dev->mode_config.funcs->fb_create(dev, file_priv
> > + ,info
> > ,mode_cmd);
> >
> > @@
> > identifier dev, file_priv, mode_cmd;
> > @@
> > struct drm_mode_config_funcs {
> > ...
> > struct drm_framebuffer *(*fb_create)(struct drm_device *dev,
> > struct drm_file *file_priv,
> > + const struct drm_format_info *info,
> > const struct drm_mode_fb_cmd2
> > *mode_cmd);
> > ...
> > };
> >
> > v2: Fix kernel docs (Laurent)
> > Fix commit msg (Geert)
> >
> > Cc: Alex Deucher <alexander.deuc...@amd.com>
> > Cc: Liviu Dudau <liviu.du...@arm.com>
> > Cc: Maxime Ripard <mrip...@kernel.org>
> > Cc: Russell King <li...@armlinux.org.uk>
> > Cc: Inki Dae <inki....@samsung.com>
> > Cc: Seung-Woo Kim <sw0312....@samsung.com>
> > Cc: Kyungmin Park <kyungmin.p...@samsung.com>
> > Cc: Patrik Jakobsson <patrik.r.jakobs...@gmail.com>
> > Cc: Chun-Kuang Hu <chunkuang...@kernel.org>
> > Cc: Philipp Zabel <p.za...@pengutronix.de>
> > Cc: Rob Clark <robdcl...@gmail.com>
> > Cc: Abhinav Kumar <quic_abhin...@quicinc.com>
> > Cc: Dmitry Baryshkov <lu...@kernel.org>
> > Cc: Sean Paul <s...@poorly.run>
> > Cc: Marijn Suijten <marijn.suij...@somainline.org>
> > Cc: Marek Vasut <ma...@denx.de>
> > Cc: Stefan Agner <ste...@agner.ch>
> > Cc: Lyude Paul <ly...@redhat.com>
> > Cc: Danilo Krummrich <d...@kernel.org>
> > Cc: Tomi Valkeinen <tomi.valkei...@ideasonboard.com>
> > Cc: Dave Airlie <airl...@redhat.com>
> > Cc: Gerd Hoffmann <kra...@redhat.com>
> > Cc: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
> > Cc: Biju Das <biju.das...@bp.renesas.com>
> > Cc: Sandy Huang <h...@rock-chips.com>
> > Cc: "Heiko Stübner" <he...@sntech.de>
> > Cc: Andy Yan <andy....@rock-chips.com>
> > Cc: Thierry Reding <thierry.red...@gmail.com>
> > Cc: Mikko Perttunen <mperttu...@nvidia.com>
> > Cc: Dave Stevenson <dave.steven...@raspberrypi.com>
> > Cc: "Maíra Canal" <mca...@igalia.com>
> > Cc: Raspberry Pi Kernel Maintenance <kernel-l...@raspberrypi.com>
> > Cc: Dmitry Osipenko <dmitry.osipe...@collabora.com>
> > Cc: Gurchetan Singh <gurchetansi...@chromium.org>
> > Cc: Chia-I Wu <olva...@gmail.com>
> > Cc: Zack Rusin <zack.ru...@broadcom.com>
> > Cc: Broadcom internal kernel review list
> > <bcm-kernel-feedback-l...@broadcom.com>
> > Cc: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com>
> > Cc: amd-...@lists.freedesktop.org
> > Cc: linux-arm-...@vger.kernel.org
> > Cc: freedr...@lists.freedesktop.org
> > Cc: nouv...@lists.freedesktop.org
> > Cc: virtualizat...@lists.linux.dev
> > Cc: spice-de...@lists.freedesktop.org
> > Cc: linux-renesas-...@vger.kernel.org
> > Cc: linux-te...@vger.kernel.org
> > Cc: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
> > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be>
> > Reviewed-by: Thomas Zimmermann <tzimmerm...@suse.de>
> > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 +
> > drivers/gpu/drm/amd/amdgpu/amdgpu_display.h | 1 +
> > .../gpu/drm/arm/display/komeda/komeda_framebuffer.c | 1 +
> > .../gpu/drm/arm/display/komeda/komeda_framebuffer.h | 1 +
> > drivers/gpu/drm/arm/malidp_drv.c | 3 ++-
> > drivers/gpu/drm/armada/armada_fb.c | 6 ++----
> > drivers/gpu/drm/armada/armada_fb.h | 3 ++-
> > drivers/gpu/drm/drm_framebuffer.c | 2 +-
> > drivers/gpu/drm/drm_gem_framebuffer_helper.c | 4 ++++
> > drivers/gpu/drm/exynos/exynos_drm_fb.c | 4 +---
> > drivers/gpu/drm/gma500/framebuffer.c | 1 +
> > drivers/gpu/drm/i915/display/intel_fb.c | 1 +
> > drivers/gpu/drm/i915/display/intel_fb.h | 1 +
> > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 5 +++--
> > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 7 ++-----
> > drivers/gpu/drm/msm/msm_drv.h | 3 ++-
> > drivers/gpu/drm/msm/msm_fb.c | 6 ++----
> > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 10 ++--------
> > drivers/gpu/drm/nouveau/nouveau_display.c | 1 +
> > drivers/gpu/drm/nouveau/nouveau_display.h | 1 +
> > drivers/gpu/drm/omapdrm/omap_fb.c | 6 ++----
> > drivers/gpu/drm/omapdrm/omap_fb.h | 3 ++-
> > drivers/gpu/drm/qxl/qxl_display.c | 1 +
> > drivers/gpu/drm/radeon/radeon_display.c | 1 +
> > drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c | 3 ++-
> > drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 3 ++-
> > drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c | 3 ++-
> > drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 7 +------
> > drivers/gpu/drm/tegra/drm.h | 1 +
> > drivers/gpu/drm/tegra/fb.c | 4 +---
> > drivers/gpu/drm/tests/drm_framebuffer_test.c | 1 +
> > drivers/gpu/drm/vc4/vc4_kms.c | 3 ++-
> > drivers/gpu/drm/virtio/virtgpu_display.c | 1 +
> > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 1 +
> > drivers/gpu/drm/xen/xen_drm_front_kms.c | 1 +
> > drivers/gpu/drm/xlnx/zynqmp_kms.c | 3 ++-
> > include/drm/drm_gem_framebuffer_helper.h | 3 +++
> > include/drm/drm_mode_config.h | 1 +
> > 38 files changed, 59 insertions(+), 49 deletions(-)
>
> [snip]
>
> > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
> > index e971e1b8a850..2e848b816218 100644
> > --- a/include/drm/drm_mode_config.h
> > +++ b/include/drm/drm_mode_config.h
> > @@ -82,6 +82,7 @@ struct drm_mode_config_funcs {
> > */
>
> It would be nice to document the new parameter here. With that
> addressed,
None of the existing parameters are documented (for any of the
mode_config hooks actually), so I think we'd need a separate
patch to deal with this.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
>
> > struct drm_framebuffer *(*fb_create)(struct drm_device *dev,
> > struct drm_file *file_priv,
> > + const struct drm_format_info *info,
> > const struct drm_mode_fb_cmd2
> > *mode_cmd);
> >
> > /**
>
> --
> Regards,
>
> Laurent Pinchart
--
Ville Syrjälä
Intel
