Re: [PATCH 09/10] drm/ast: Gen7: Disable VGASR0[1] as on Gen4+

[Jocelyn Falempe]

On 02/07/2025 15:12, Thomas Zimmermann wrote:

Set VGACRB6[5], which disables asynchronous sequencer resets via
VGASR0[1]. This was most likely an oversight when adding support
for Gen7. Aligns Gen7 with the earlier Gen4+.

Thanks, it looks good to me.

Reviewed-by: Jocelyn Falempe <jfale...@redhat.com>

Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
---
  drivers/gpu/drm/ast/ast_2600.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/ast/ast_2600.c b/drivers/gpu/drm/ast/ast_2600.c
index f9b96c631d4c..a426a981949e 100644
--- a/drivers/gpu/drm/ast/ast_2600.c
+++ b/drivers/gpu/drm/ast/ast_2600.c
@@ -60,6 +60,7 @@ void ast_2600_set_def_ext_reg(struct ast_device *ast)

/* Enable RAMDAC for A1 */

        reg = 0x04;
+       reg |= 0x20;
        ast_set_index_reg_mask(ast, AST_IO_VGACRI, 0xb6, 0xff, reg);
  }