On Fri, 2025-06-20 at 22:22 +0200, Lucas Stach wrote: > > > @@ -1807,6 +1808,11 @@ static int etnaviv_gpu_bind(struct device > > *dev, struct device *master, > > ret = -ENXIO; > > goto out_sched; > > } > > + > > + if (etnaviv_flop_reset_ppu_require(&gpu->identity) && > > + !priv->flop_reset_data_ppu) > > + etnaviv_flop_reset_ppu_init(priv); > > + > I don't see why you would need to do this in the bind callback. You > should be able to move this to etnaviv_gpu_init(), so you have the > needed identification data. gpu_init is also executed serially over > all GPUs in the device, so there is no problem with potential races > there.
I moved this here because you wrote before: > But then you should allocate this buffer > in etnaviv_gpu_bind to avoid races between GPUs starting up and > trying to allocate this global memory. If etnaviv_gpu_init() is fine, I'll move it there. Regards, Gert
