On Wed, Jun 4, 2025 at 10:25 AM Heiko Stübner <he...@sntech.de> wrote: > > Am Mittwoch, 4. Juni 2025, 09:57:14 Mitteleuropäische Sommerzeit schrieb > Tomeu Vizoso: > > Add the bindings for the Neural Processing Unit IP from Rockchip. > > > > v2: > > - Adapt to new node structure (one node per core, each with its own > > IOMMU) > > - Several misc. fixes from Sebastian Reichel > > > > v3: > > - Split register block in its constituent subblocks, and only require > > the ones that the kernel would ever use (Nicolas Frattaroli) > > - Group supplies (Rob Herring) > > - Explain the way in which the top core is special (Rob Herring) > > > > v4: > > - Change required node name to npu@ (Rob Herring and Krzysztof Kozlowski) > > - Remove unneeded items: (Krzysztof Kozlowski) > > - Fix use of minItems/maxItems (Krzysztof Kozlowski) > > - Add reg-names to list of required properties (Krzysztof Kozlowski) > > - Fix example (Krzysztof Kozlowski) > > > > v5: > > - Rename file to rockchip,rk3588-rknn-core.yaml (Krzysztof Kozlowski) > > - Streamline compatible property (Krzysztof Kozlowski) > > > > v6: > > - Remove mention to NVDLA, as the hardware is only incidentally related > > (Kever Yang) > > - Mark pclk and npu clocks as required by all clocks (Rob Herring) > > > > Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.com> > > Signed-off-by: Tomeu Vizoso <to...@tomeuvizoso.net> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org> > > --- > > .../bindings/npu/rockchip,rk3588-rknn-core.yaml | 144 > > +++++++++++++++++++++ > > 1 file changed, 144 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/npu/rockchip,rk3588-rknn-core.yaml > > b/Documentation/devicetree/bindings/npu/rockchip,rk3588-rknn-core.yaml > > new file mode 100644 > > index > > 0000000000000000000000000000000000000000..9a5e9e213912d0997da2f6ae26189adf044dcc7b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/npu/rockchip,rk3588-rknn-core.yaml > > @@ -0,0 +1,144 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/npu/rockchip,rk3588-rknn-core.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Neural Processing Unit IP from Rockchip > > + > > +maintainers: > > + - Tomeu Vizoso <to...@tomeuvizoso.net> > > + > > +description: > > + Rockchip IP for accelerating inference of neural networks. > > + > > + There is to be a node per each core in the NPU. In Rockchip's design > > there > > + will be one core that is special and needs to be powered on before any > > of the > > + other cores can be used. This special core is called the top core and > > should > > + have the compatible string that corresponds to top cores. > > + > > +properties: > > + $nodename: > > + pattern: '^npu@[a-f0-9]+$' > > + > > + compatible: > > + enum: > > + - rockchip,rk3588-rknn-core-top > > + - rockchip,rk3588-rknn-core > > + > > + reg: > > + maxItems: 3 > > + > > + reg-names: > > + items: > > + - const: pc > > + - const: cna > > + - const: core > > + > > + clocks: > > + maxItems: 4 > > + > > + clock-names: > > + items: > > + - const: aclk > > + - const: hclk > > + - const: npu > > + - const: pclk > > + > > + interrupts: > > + maxItems: 1 > > + > > + iommus: > > + maxItems: 1 > > + > > + npu-supply: true > > + > > + power-domains: > > + maxItems: 1 > > + > > + resets: > > + maxItems: 2 > > + > > + reset-names: > > + items: > > + - const: srst_a > > + - const: srst_h > > + > > + sram-supply: true > > + > > +required: > > + - compatible > > + - reg > > + - reg-names > > + - clocks > > + - clock-names > > + - interrupts > > + - iommus > > + - power-domains > > + - resets > > + - reset-names > > + - npu-supply > > + - sram-supply > > + > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - rockchip,rknn-core-top > > should be rockchip,rk3588-rknn-core-top I think > > > + then: > > + properties: > > + clocks: > > + minItems: 4 > > + > > + clock-names: > > + minItems: 4 > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - rockchip,rknn-core > > should be rockchip,rk3588-rknn-core
Thanks. Actually, all the addOf section is not needed any more as we now know that from a resources point of view all cores are the same. Cheers, Tomeu > > + then: > > + properties: > > + clocks: > > + maxItems: 2 > > + clock-names: > > + maxItems: 2 > > > Heiko > >
