On Tue, May 27, 2025 at 03:17:43AM -0400, Abdulrasaq Lawani wrote: > revert promotion of overview diagram title to that > of previous commit in introduction.rst >
The patch description doesn't really describe the diff below, which is to add overview diagram instead. Maybe you can replace that with from your v1? > diff --git a/Documentation/gpu/introduction.rst > b/Documentation/gpu/introduction.rst > index > 3cd0c8860b949408ed570d3f9384edd5f03df002..a8d3f953a470180b395ec52a45d0f3f4561424e0 > 100644 > --- a/Documentation/gpu/introduction.rst > +++ b/Documentation/gpu/introduction.rst > @@ -14,7 +14,45 @@ including the TTM memory manager, output configuration and > mode setting, > and the new vblank internals, in addition to all the regular features > found in current kernels. > > -[Insert diagram of typical DRM stack here] > +Overview of the Linux DRM Architecture > +-------------------------------------- > +:: > + > + +-----------------------------+ > + | User-space Apps | > + | (Games, Browsers, ML, etc.) | > + +-----------------------------+ > + | > + v > + +---------------------------------------+ > + | Graphics APIs | Compute APIs | > + | (OpenGL, Vulkan) | (OpenCL, CUDA) | > + +---------------------------------------+ > + | | > + v v > + +---------------------+ +-----------------------+ > + | User-space Driver | | Compute Runtime | > + | (Mesa, AMD/NVIDIA) | | (OpenCL, CUDA, ROCm) | > + +---------------------+ +-----------------------+ > + | | > + +--------+----------+ > + | > + v > + +-----------------------+ > + | libdrm (DRM API) | > + +-----------------------+ > + | > + v > + +-------------------------------------------+ > + | Kernel DRM/KMS Driver (i915, amdgpu, | > + | nouveau, etc.) | > + +-------------------------------------------+ > + | | > + v v > + +----------------+ +-------------------+ > + | GPU Display HW | | GPU Compute Units | > + +----------------+ +-------------------+ > + > > Style Guidelines > ================ > The diff itself looks good. Thanks. -- An old man doll... just what I always wanted! - Clara
signature.asc
Description: PGP signature
