Re: [PATCH v2] accel/ivpu: Fix warning in ivpu_gem_bo_free()

[Lizhi Hou]

On 5/28/25 10:12, Jacek Lawrynowicz wrote:

Don't WARN if imported buffers are in use in ivpu_gem_bo_free() as they
can be indeed used in the original context/driver.

Fixes: 647371a6609d ("accel/ivpu: Add GEM buffer object management")
Cc: sta...@vger.kernel.org # v6.3
Signed-off-by: Jacek Lawrynowicz <jacek.lawrynow...@linux.intel.com>
---
v2: Use drm_gem_is_imported() to check if the buffer is imported.
---
  drivers/accel/ivpu/ivpu_gem.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c
index c193a80241f5f..5ff0bac739fc9 100644
--- a/drivers/accel/ivpu/ivpu_gem.c
+++ b/drivers/accel/ivpu/ivpu_gem.c
@@ -278,7 +278,8 @@ static void ivpu_gem_bo_free(struct drm_gem_object *obj)
        list_del(&bo->bo_list_node);
        mutex_unlock(&vdev->bo_list_lock);

- drm_WARN_ON(&vdev->drm, !dma_resv_test_signaled(obj->resv, DMA_RESV_USAGE_READ));

+       drm_WARN_ON(&vdev->drm, !drm_gem_is_imported(&bo->base.base) &&
+                   !dma_resv_test_signaled(obj->resv, DMA_RESV_USAGE_READ));

Reviewed-by: Lizhi Hou <lizhi....@amd.com>

        drm_WARN_ON(&vdev->drm, ivpu_bo_size(bo) == 0);
        drm_WARN_ON(&vdev->drm, bo->base.vaddr);