On Wed, May 28, 2025, at 12:31, Andy Shevchenko wrote: > On Wed, May 28, 2025 at 03:17:03AM -0700, Christopher Snowhill wrote: >> On Wed May 28, 2025 at 3:03 AM PDT, Arnd Bergmann wrote: >> > On Wed, May 28, 2025, at 11:34, Andy Shevchenko wrote: >> >> On Tue, May 27, 2025 at 03:55:46PM -0500, Lucas De Marchi wrote: >> > I think ACPI_VIDEO is at the center here, and changing all the >> > 'select ACPI_VIDEO if ACPI' instances to >> > 'depends on ACPI_VIDEO || !ACPI_VIDEO' would solve a lot of >> >> Maybe you meant 'depends on ACPI_VIDEO || !ACPI' ? > > I believe not. The depends on FOO || FOO=n is idiomatic in Kconfig.
It depends on what we want here. 'ACPI_VIDEO || !ACPI' would be the direct equivalent of the existing 'select ACPI_VIDEO if ACPI', while 'ACPI_VIDEO || !ACPI_VIDEO' would allow building with ACPI=y and ACPI_VIDEO=n, which is not possible today. I'd probably start with the version that Christopher suggested to have a lower regression risk. Arnd