Hi Maxime, On Thu, 22 May 2025 16:57:30 +0200 Maxime Ripard <mrip...@kernel.org> wrote:
[...] > > As the commit was a mistake, I'm applying the revert by the end of this > > week (i.e. on Friday) unless there are better instructions. > > Given the lack of answers, and that it looks correct to me, just leave > it there. We can always revert later on if things turned out to be > broken. OK, I'll leave the commit and drop the revert in v4. > > > drm: convert many bridge drivers from devm_kzalloc() to > > > devm_drm_bridge_alloc() API > > > > This patch affects multiple drivers. Running get_maintainers.pl > > points at Shawn Guo's repository. After reviewing the MAINTAINERS file, > > this looks like due to the 'N:' line in: > > > > ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > > M: Shawn Guo <shawn...@kernel.org> > > M: Sascha Hauer <s.ha...@pengutronix.de> > > R: Pengutronix Kernel Team <ker...@pengutronix.de> > > ... > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git > > N: imx > > ... > > > > (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L2511-2528) > > > > Here 'imx' matches the 'drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c' > > file that is touched by the patch. That regexp appears overly generic to > > me. > > I agree, or at least, we shouldn't wait for Shawn or Sasha... > > > Shawn, can it be fixed by making it less generic? > > > > If not, can we at least add a band-aid 'X:' entry for > > drivers/gpu/drm/bridge/imx? > > > > I think the other matching entry is the one to consider: > > > > DRM DRIVERS FOR FREESCALE IMX BRIDGE > > M: Liu Ying <victor....@nxp.com> > > L: dri-devel@lists.freedesktop.org > > S: Maintained > > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml > > F: > > Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-combiner.yaml > > F: > > Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml > > F: > > Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml > > F: drivers/gpu/drm/bridge/imx/ > > > > (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L7940-7948) > > > > ... As long as Ying is fine with it, because it does look like they are > the actual maintainer. Ack, thanks for confirming this. Bottom line, given that large patch has your Acked-by, and given the shawnguo repo was ruled out, the conclusion is it can apply it to drm-misc-next. Having that large patch applied will be relieving me a lot! I think next time I'm going to split any imilar change in per-driver patches, even if it is spatch-automated. > > > drm/todo: add entry to remove devm_drm_put_bridge() > > > > This involves documentation maintained on another tree. Where should it > > be applied? There are two matching entries in MAINTAINERS: > > > > * DRM DRIVERS -> the drm tree > > * DRM DRIVERS AND MISC GPU PATCHES -> the drm-misc tree > > > > To me it looks like the second is obviously the closest match as we are > > dealing with DRM bridges, so I'm applying this as well on Friday unless > > there are better instructions. > > Yes, they should be applied to drm-misc. OK, will do soon. > That being said, putting a two days timeout on *any* email is really > over-the-top. I doubt you reply to any of your mail in such a short > timeframe. We have rules for a reason, I'd expect you to follow them, no > matter how frustrating the lack of answers can be. Apologies if that was too much. I was indeed nervous about the revert. A patch got applied by mistake and I believe it should have been reverted very quickly, if need be. Both Louis and I didn't want to break the process again. So we asked, but not having answer after 2+ weeks I must admit I got a bit nervous about it. Sorry about that and thanks for the feedback about my questions. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
