On Wed, 27 Apr 2011 16:10:59 +1000 christopher.halse.rogers at canonical.com wrote:
> From: Christopher James Halse Rogers <christopher.halse.rogers at > canonical.com> > > Signed-off-by: Christopher James Halse Rogers <christopher.halse.rogers at > canonical.com> > --- > drivers/gpu/drm/drm_irq.c | 39 ++++++++++++++++----------------------- > 1 files changed, 16 insertions(+), 23 deletions(-) > Oh I see you already addressed my last comment. :) I think Michel is right about the put; the event queue holds the ref and the emit should drop it, so keeping them together seems good to me. Other than that, Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org> same for the first patch now that you've addressed my cleanup issue. -- Jesse Barnes, Intel Open Source Technology Center
