On 5/9/2025 11:12 AM, Krzysztof Kozlowski wrote: > On 08/05/2025 18:19, Akhil P Oommen wrote: >> From: Jie Zhang <quic_ji...@quicinc.com> >> >> Document Adreno 623 GMU in the dt-binding specification. >> >> Signed-off-by: Jie Zhang <quic_ji...@quicinc.com> >> Signed-off-by: Akhil P Oommen <quic_akhi...@quicinc.com> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org> > > Drop. You changed patch significantly, like 90%!
Aah! my bad. This is actually a new patch which I mentioned in the cover letter: "Update dt-bindings yaml with a new patch#1" I will update the subject and drop the R-b tag. > >> --- >> .../devicetree/bindings/display/msm/gmu.yaml | 34 >> ++++++++++++++++++++++ >> 1 file changed, 34 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml >> b/Documentation/devicetree/bindings/display/msm/gmu.yaml >> index >> 4392aa7a4ffe2492d69a21e067be1f42e00016d8..afc1879357440c137cadeb2d9a74ae8459570a25 >> 100644 >> --- a/Documentation/devicetree/bindings/display/msm/gmu.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/gmu.yaml >> @@ -124,6 +124,40 @@ allOf: >> contains: >> enum: >> - qcom,adreno-gmu-623.0 > > I don't understand. 623 is already here, you document nothing new. This > makes no sense, I never, absolutely never reviewed code like this. The clock list is different for 623. We are removing smmu_clk for 623. -Akhil > > NAK > > > Best regards, > Krzysztof
