On 08/05/2025 08:43, Chaoyi Chen wrote: > From: Chaoyi Chen <chaoyi.c...@rock-chips.com> > > Convert cdn-dp-rockchip.txt to yaml. > > Tested with: > > 1. make ARCH=arm64 dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip,cdn-dp.yaml > > 2. make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip,cdn-dp.yaml
Drop. You do not have to embed in commit msg standard makefile targets. We all know how to use it. You do not do it for C files, do you? > > Signed-off-by: Chaoyi Chen <chaoyi.c...@rock-chips.com> > --- ... > - }; > diff --git > a/Documentation/devicetree/bindings/display/rockchip/rockchip,cdn-dp.yaml > b/Documentation/devicetree/bindings/display/rockchip/rockchip,cdn-dp.yaml > new file mode 100644 > index 000000000000..ed68b48a6743 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,cdn-dp.yaml Filename matching compatible. > @@ -0,0 +1,148 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/rockchip/rockchip,cdn-dp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip RK3399 specific extensions to the CDN Display Port > + > +maintainers: > + - Andy Yan <andy....@rock-chip.com> > + - Heiko Stuebner <he...@sntech.de> > + - Sandy Huang <h...@rock-chips.com> > + > +properties: > + compatible: > + items: > + - const: rockchip,rk3399-cdn-dp > + > + reg: > + description: > + CDN DP core register Missing constraints. Drop description. Just look at other bindings. > + > + assigned-clock-rates: true > + assigned-clocks: true Drop these two > + > + clocks: > + minItems: 4 No, look at other bindings. > + > + clock-names: > + items: > + - const: core-clk > + - const: pclk > + - const: spdif > + - const: grf > + > + extcon: > + description: > + Phandle to the extcon device providing the cable state for the DP phy. Missing type, unless you could not add a type because of conflicts? This should be really fixed... > + > + interrupts: > + maxItems: 1 and here is maxItems. Why in other places you put minItems? > + > + phys: > + minItems: 1 > + maxItems: 2 Why is this flexible? It wasn't in original binding and you must document all the changes done to the binding in commit msg. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: Input of the CDN DP > + properties: > + endpoint@0: > + description: Connection to the VOPB > + endpoint@1: > + description: Connection to the VOPL > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: Output of the CDN DP > + > + required: > + - port@0 > + - port@1 > + > + power-domains: > + maxItems: 1 > + > + resets: > + minItems: 4 No, look at other bindings. > + > + reset-names: > + items: > + - const: spdif > + - const: dptx > + - const: apb > + - const: core > + > + rockchip,grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + This SoC makes use of GRF regs. For what? You did not say anything useful above, so instead explain the purpose. > + > + "#sound-dai-cells": > + const: 1 Missing dai-common ref, unless this is not a DAI? > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + - phys > + - ports > + - resets > + - reset-names > + - rockchip,grf > + > +unevaluatedProperties: false Where is any $ref? additionalProperties instead or add proper ref > + > +examples: > + - | > + #include <dt-bindings/clock/rk3399-cru.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/rk3399-power.h> > + cdn_dp: dp@fec00000 { Drop unused label > + compatible = "rockchip,rk3399-cdn-dp"; > + reg = <0x0 0xfec00000 0x0 0x100000>; > + assigned-clocks = <&cru SCLK_DP_CORE>; > + assigned-clock-rates = <100000000>; > + interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cru SCLK_DP_CORE>, <&cru PCLK_DP_CTRL>, <&cru > SCLK_SPDIF_REC_DPTX>, > + <&cru PCLK_VIO_GRF>; Best regards, Krzysztof
