On Wed, Apr 30, 2025 at 01:09:31PM -0700, Abhinav Kumar wrote:
>
>
> On 4/13/2025 9:32 AM, Dmitry Baryshkov wrote:
> > If the Adreno device is used in a headless mode, there is no need to
> > build all KMS components. Build corresponding parts conditionally, only
> > selecting them if modeset support is actually required.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@oss.qualcomm.com>
> > ---
> > drivers/gpu/drm/msm/Kconfig | 14 ++++++
> > drivers/gpu/drm/msm/Makefile | 16 +++----
> > drivers/gpu/drm/msm/dp/dp_debug.c | 4 ++
> > drivers/gpu/drm/msm/msm_debugfs.c | 92
> > ++++++++++++++++++++++-----------------
> > drivers/gpu/drm/msm/msm_drv.h | 7 ++-
> > drivers/gpu/drm/msm/msm_kms.h | 23 ++++++++++
> > 6 files changed, 108 insertions(+), 48 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h
> > index
> > a65077855201746c37ee742364b61116565f3794..5f4d3f050c1fde71c405a1ebf516f4f5a396cfc4
> > 100644
> > --- a/drivers/gpu/drm/msm/msm_drv.h
> > +++ b/drivers/gpu/drm/msm/msm_drv.h
> > @@ -88,6 +88,7 @@ struct msm_drm_private {
> > /* subordinate devices, if present: */
> > struct platform_device *gpu_pdev;
> > +#ifdef CONFIG_DRM_MSM_KMS
> > /* possibly this should be in the kms component, but it is
> > * shared by both mdp4 and mdp5..
> > */
>
> As the comment says, I am also thinking that this should be part of msm_kms
> struct, to avoid ifdefs. I didnt follow the second half of the comment that
> this is shared by both mdp4/mdp5. Why does that prevent it from being in the
> kms component?
Indeed, there are no such limitations nowadays.
--
With best wishes
Dmitry
