On Tue, 29 Apr 2025 19:18:01 -0700 Jeff Layton wrote: > On Tue, 2025-04-29 at 16:27 -0700, Jakub Kicinski wrote: > > On Mon, 28 Apr 2025 11:26:27 -0700 Jeff Layton wrote: > > > Allow pr_ostream to also output directly to a seq_file without an > > > intermediate buffer. > > > > > > Reviewed-by: Andrew Lunn <and...@lunn.ch> > > > Signed-off-by: Jeff Layton <jlay...@kernel.org> > > > > lib/ref_tracker.c:316:12: warning: unused function > > 'ref_tracker_dir_seq_print' [-Wunused-function] > > 316 | static int ref_tracker_dir_seq_print(struct ref_tracker_dir *dir, > > struct seq_file *seq) > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > The caller ends up being added in patch #6. I think the only thing I > can do here to silence this is to squash this patch into that one. > > I kind of don't like doing that here because I think the patches are > conceptually separate, and it'll make for a rather large patch. > > Let me know what you prefer.
Would it work to make the fops very dumbed down - return an error from open. And then implement the seqfile output as the next patch?
