Hi Jani,
On 4/28/25 12:52 PM, Jani Nikula wrote:
> On Fri, 25 Apr 2025, Cristian Ciocaltea <cristian.ciocal...@collabora.com>
> wrote:
>> Factor out the HDMI connector initialization from
>> drm_kunit_helper_connector_hdmi_init_funcs() into a common
>> __connector_hdmi_init() function, while extending its functionality to
>> allow setting custom (i.e. non-default) EDID data.
>>
>> Introduce a macro as a wrapper over the new helper to allow dropping the
>> open coded EDID setup from all test cases.
>>
>> The actual conversion will be handled separately; for now just apply it
>> to drm_kunit_helper_connector_hdmi_init() helper.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocal...@collabora.com>
>> ---
>> drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 46
>> +++++++++++++---------
>> 1 file changed, 28 insertions(+), 18 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
>> b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
>> index
>> c8dc6fa0f925e35e9903a18bac7f78f9d8165960..36734639d19a3f279abc4631eb19d5c2b20ca315
>> 100644
>> --- a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
>> +++ b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
>> @@ -140,10 +140,11 @@ static const struct drm_connector_funcs
>> dummy_connector_funcs = {
>>
>> static
>> struct drm_atomic_helper_connector_hdmi_priv *
>> -drm_kunit_helper_connector_hdmi_init_funcs(struct kunit *test,
>> - unsigned int formats,
>> - unsigned int max_bpc,
>> - const struct
>> drm_connector_hdmi_funcs *hdmi_funcs)
>> +__connector_hdmi_init(struct kunit *test,
>> + unsigned int formats,
>> + unsigned int max_bpc,
>> + const struct drm_connector_hdmi_funcs *hdmi_funcs,
>> + const char *edid_data, size_t edid_len)
>
> char* is weird for EDID data, but it's a pre-existing thing, and
> actually making it unsigned char or u8 isn't much better.
>
> A follow-up could switch edid_data to just const void *, and ditto for
> set_connector_edid() and current_edid member in struct
> drm_atomic_helper_connector_hdmi_priv.
Noted for next revision (if required), otherwise I'll handle it separately.
Thanks,
Cristian
