On Wed, Apr 23, 2025 at 06:32:07PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <a...@arndb.de>
>
> goa_even_valid is only initialized in one branch but not the other:
>
> drivers/gpu/drm/panel/panel-himax-hx8279.c:838:6: error: variable
> 'goa_even_valid' is used uninitialized whenever 'if' condition is false
> [-Werror,-Wsometimes-uninitialized]
> 838 | if (num_zero == ARRAY_SIZE(desc->goa_even_timing))
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/panel/panel-himax-hx8279.c:842:23: note: uninitialized use
> occurs here
> 842 | if (goa_odd_valid != goa_even_valid)
> | ^~~~~~~~~~~~~~
>
> Change the initialization to set it to the value of the condition instead.
>
> Fixes: 38d42c261389 ("drm: panel: Add driver for Himax HX8279 DDIC panels")
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> ---
> drivers/gpu/drm/panel/panel-himax-hx8279.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.barysh...@oss.qualcomm.com>
>
--
With best wishes
Dmitry
