On 3/15/25 3:57 PM, Barnabás Czémán wrote: > Add initial support for Xiaomi Redmi 3S (land). > > Signed-off-by: Barnabás Czémán <barnabas.cze...@mainlining.org> > ---
[...] > + headphones_switch: audio-switch { > + compatible = "simple-audio-amplifier"; > + enable-gpios = <&tlmm 129 GPIO_ACTIVE_HIGH>; > + sound-name-prefix = "Headphones Switch"; > + pinctrl-0 = <&headphones_switch_default>; > + pinctrl-names = "default"; > + }; We've had a similar change lately https://lore.kernel.org/linux-arm-msm/20250327100633.11530-1-srinivas.kandaga...@linaro.org/ I think this could be some sort of a drivers/mux/... [...] > +&pm8937_resin { > + linux,code = <KEY_VOLUMEDOWN>; > + status = "okay"; > +}; Please also unify the style such that there's a newline before status Looks good otherwise Konrad