In _hl_mmu_v2_hr_map(), If hl_mmu_get_hop_pte_phys_addr() fail to
get physical address, the return address will be set as U64_MAX.
Hence, the return value of hl_mmu_get_hop_pte_phys_addr() must
be checked to prevent invalid address access. Add error handling
and propagate return code to caller function to fix this issue.
Fixes: 8aa1e1e60553 ("habanalabs: add gaudi2 MMU support")
Cc: sta...@vger.kernel.org # v6.0+
Signed-off-by: Wentao Liang <vu...@iscas.ac.cn>
---
drivers/accel/habanalabs/common/mmu/mmu_v2_hr.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/accel/habanalabs/common/mmu/mmu_v2_hr.c
b/drivers/accel/habanalabs/common/mmu/mmu_v2_hr.c
index 31507b2a431b..cdade07e22c5 100644
--- a/drivers/accel/habanalabs/common/mmu/mmu_v2_hr.c
+++ b/drivers/accel/habanalabs/common/mmu/mmu_v2_hr.c
@@ -253,6 +253,11 @@ static int _hl_mmu_v2_hr_map(struct hl_ctx *ctx,
hop_pte_phys_addr[i] = hl_mmu_get_hop_pte_phys_addr(ctx,
mmu_prop, i,
hops_pgt_info[i]->phys_addr,
scrambled_virt_addr);
+ if (hop_pte_phys_addr[i] == U64_MAX) {
+ rc = -EINVAL;
+ goto err;
+ }
+
curr_pte = *(u64 *) (uintptr_t) hl_mmu_hr_pte_phys_to_virt(ctx,
hops_pgt_info[i],
hop_pte_phys_addr[i],
ctx->hdev->asic_prop.pmmu.hop_table_size);
--
2.42.0.windows.2
