From: "Dr. David Alan Gilbert" <li...@treblig.org>
qxl_debugfs_add_files() has been unused since 2022's
commit d0719e09264b ("drm/qxl: Use TTM builtin resource manager debugfs
code")
Remove it.
This now leaves the debugfs_count and debugfs members of struct
qxl_device unused. Remove them.
QXL_DEBUGFS_MAX_COMPONENTS was only used as the size of the debugfs[]
array. Remove it.
Signed-off-by: Dr. David Alan Gilbert <li...@treblig.org>
---
drivers/gpu/drm/qxl/qxl_debugfs.c | 29 -----------------------------
drivers/gpu/drm/qxl/qxl_drv.h | 10 ----------
2 files changed, 39 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_debugfs.c
b/drivers/gpu/drm/qxl/qxl_debugfs.c
index 2d9ed3b94574..bdfce1a8f006 100644
--- a/drivers/gpu/drm/qxl/qxl_debugfs.c
+++ b/drivers/gpu/drm/qxl/qxl_debugfs.c
@@ -95,32 +95,3 @@ qxl_debugfs_init(struct drm_minor *minor)
qxl_ttm_debugfs_init(dev);
#endif
}
-
-void qxl_debugfs_add_files(struct qxl_device *qdev,
- struct drm_info_list *files,
- unsigned int nfiles)
-{
- unsigned int i;
-
- for (i = 0; i < qdev->debugfs_count; i++) {
- if (qdev->debugfs[i].files == files) {
- /* Already registered */
- return;
- }
- }
-
- i = qdev->debugfs_count + 1;
- if (i > QXL_DEBUGFS_MAX_COMPONENTS) {
- DRM_ERROR("Reached maximum number of debugfs components.\n");
- DRM_ERROR("Report so we increase
QXL_DEBUGFS_MAX_COMPONENTS.\n");
- return;
- }
- qdev->debugfs[qdev->debugfs_count].files = files;
- qdev->debugfs[qdev->debugfs_count].num_files = nfiles;
- qdev->debugfs_count = i;
-#if defined(CONFIG_DEBUG_FS)
- drm_debugfs_create_files(files, nfiles,
- qdev->ddev.primary->debugfs_root,
- qdev->ddev.primary);
-#endif
-}
diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h
index a6184aaebf62..ea977c238b27 100644
--- a/drivers/gpu/drm/qxl/qxl_drv.h
+++ b/drivers/gpu/drm/qxl/qxl_drv.h
@@ -59,8 +59,6 @@ struct iosys_map;
#define DRIVER_MINOR 1
#define DRIVER_PATCHLEVEL 0
-#define QXL_DEBUGFS_MAX_COMPONENTS 32
-
extern int qxl_num_crtc;
#define QXL_INTERRUPT_MASK (\
@@ -227,10 +225,6 @@ struct qxl_device {
wait_queue_head_t io_cmd_event;
struct work_struct client_monitors_config_work;
- /* debugfs */
- struct qxl_debugfs debugfs[QXL_DEBUGFS_MAX_COMPONENTS];
- unsigned int debugfs_count;
-
struct mutex update_area_mutex;
struct idr surf_id_idr;
@@ -423,10 +417,6 @@ void qxl_gem_prime_vunmap(struct drm_gem_object *obj,
/* qxl_irq.c */
int qxl_irq_init(struct qxl_device *qdev);
-void qxl_debugfs_add_files(struct qxl_device *qdev,
- struct drm_info_list *files,
- unsigned int nfiles);
-
int qxl_surface_id_alloc(struct qxl_device *qdev,
struct qxl_bo *surf);
void qxl_surface_id_dealloc(struct qxl_device *qdev,
--
2.49.0
