On Wed, Apr 2, 2025 at 5:09 PM Ondřej Jirman <m...@xff.cz> wrote: > Hi Anusha, > > On Wed, Apr 02, 2025 at 11:23:45AM -0400, Anusha Srivatsa wrote: > > Move to using the new API devm_drm_panel_alloc() to allocate the > > panel. > > > > Signed-off-by: Anusha Srivatsa <asriv...@redhat.com> > > --- > > drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c > b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c > > index > ff39f5dd4097e8da0a0e16c50c5bfd45c078d91c..d87b7eefe9beedd290fb59065b389b3315c85720 > 100644 > > --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c > > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c > > @@ -490,9 +490,11 @@ static int ili9341_dpi_probe(struct spi_device > *spi, struct gpio_desc *dc, > > struct ili9341 *ili; > > int ret; > > > > - ili = devm_kzalloc(dev, sizeof(struct ili9341), GFP_KERNEL); > > - if (!ili) > > - return -ENOMEM; > > + ili = devm_drm_panel_alloc(dev, struct ili9341, panel, > > + &ili9341_dpi_funcs, > > + DRM_MODE_CONNECTOR_DPI); > > + if (IS_ERR(ili)) > > + return PTR_ERR(ili); > > > > ili->dbi = devm_kzalloc(dev, sizeof(struct mipi_dbi), > > GFP_KERNEL); > > Unlike in other patches, in this one you did not remove: > > > https://elixir.bootlin.com/linux/v6.13.7/source/drivers/gpu/drm/panel/panel-ilitek-ili9341.c#L529 > > drm_panel_init(&ili->panel, dev, &ili9341_dpi_funcs, > DRM_MODE_CONNECTOR_DPI); > > Unintentional? > > Yup. Unintentional. WIll remove this in the next iteration.
Thanks! Anusha > kind regards, > o. > > > -- > > 2.48.1 > > > >
