On Thu, Mar 20, 2025 at 06:14:51PM +0800, Yongbang Shi wrote: > From: Baihan Li <libai...@huawei.com> > > Add registering drm_aux and use it to get connector edid with drm > functions. Add ddc channel in connector initialization to put drm_aux > in drm_connector. > > Signed-off-by: Baihan Li <libai...@huawei.com> > Signed-off-by: Yongbang Shi <shiyongb...@huawei.com> > Reviewed-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org> > --- > ChangeLog: > v7 -> v8: > - use drm_edid_read() in hibmc_dp_connector_get_modes(), suggested by Jani > Nikula > v6 -> v7: > - add if statement about drm aux in hibmc_dp_connector_get_modes(), > suggested by Jani Nikula > v5 -> v6: > - move the detect_ctx() to the patch 7/9. > v2 -> v3: > - Capitalized EDID and AUX, suggested by Dmitry Baryshkov. > v1 -> v2: > - deleting type conversion, suggested by Dmitry Baryshkov. > - deleting hibmc_dp_connector_get_modes() and using > drm_connector_helper_get_modes(), suggested by Dmitry Baryshkov. > --- > drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c | 3 +- > .../gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c | 31 ++++++++++++++++--- > .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 5 +++ > 3 files changed, 33 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c > b/drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c > index ded9e7ce887a..e0bb9b14d9d8 100644 > --- a/drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c > +++ b/drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c > @@ -161,7 +161,8 @@ void hibmc_dp_aux_init(struct hibmc_dp *dp) > HIBMC_DP_MIN_PULSE_NUM); > > dp->aux.transfer = hibmc_dp_aux_xfer; > - dp->aux.is_remote = 0; > + dp->aux.name = kasprintf(GFP_KERNEL, "HIBMC DRM dp aux");
As being discussed in the feedback for v7, this is a memory leak. Can you simply assign the string here? > + dp->aux.drm_dev = dp->drm_dev; > drm_dp_aux_init(&dp->aux); > dp->dp_dev->aux = &dp->aux; > } -- With best wishes Dmitry
