The ast driver protects the commit tail against concurrent reads
of the display modes by acquiring a lock. The comment is misleading
as the lock is not released in atomic_flush, but at the end of the
commit-tail helper. Rewrite the comment.

Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
Fixes: 1fe182154984 ("drm/ast: Acquire I/O-register lock in atomic_commit_tail 
function")
Cc: Thomas Zimmermann <tzimmerm...@suse.de>
Cc: Jocelyn Falempe <jfale...@redhat.com>
Cc: Dave Airlie <airl...@redhat.com>
Cc: dri-devel@lists.freedesktop.org
Cc: <sta...@vger.kernel.org> # v6.2+
---
 drivers/gpu/drm/ast/ast_mode.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 4cac5c7f4547..20fbea11b710 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -939,9 +939,9 @@ static void 
ast_mode_config_helper_atomic_commit_tail(struct drm_atomic_state *s
 
        /*
         * Concurrent operations could possibly trigger a call to
-        * drm_connector_helper_funcs.get_modes by trying to read the
-        * display modes. Protect access to I/O registers by acquiring
-        * the I/O-register lock. Released in atomic_flush().
+        * drm_connector_helper_funcs.get_modes by reading the display
+        * modes. Protect access to registers by acquiring the modeset
+        * lock.
         */
        mutex_lock(&ast->modeset_lock);
        drm_atomic_helper_commit_tail(state);
-- 
2.48.1

Reply via email to