On Mon, Mar 17, 2025 at 6:14 AM Neil Armstrong <neil.armstr...@linaro.org> wrote:
> On 16/03/2025 18:40, Anusha Srivatsa wrote: > > > > > > On Fri, Mar 14, 2025 at 10:20 AM Doug Anderson <diand...@chromium.org > <mailto:diand...@chromium.org>> wrote: > > > > Hi, > > > > On Thu, Mar 13, 2025 at 9:47 PM Anusha Srivatsa <asriv...@redhat.com > <mailto:asriv...@redhat.com>> wrote: > > > > > > @@ -181,24 +162,15 @@ static int r63353_panel_prepare(struct > drm_panel *panel) > > > static int r63353_panel_deactivate(struct r63353_panel *rpanel) > > > { > > > struct mipi_dsi_device *dsi = rpanel->dsi; > > > - struct device *dev = &dsi->dev; > > > - int ret; > > > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi }; > > > > > > - ret = mipi_dsi_dcs_set_display_off(dsi); > > > - if (ret < 0) { > > > - dev_err(dev, "Failed to set display OFF (%d)\n", > ret); > > > - return ret; > > > - } > > > + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); > > > > > > - usleep_range(5000, 10000); > > > + mipi_dsi_usleep_range(&dsi_ctx, 5000, 10000); > > > > > > - ret = mipi_dsi_dcs_enter_sleep_mode(dsi); > > > - if (ret < 0) { > > > - dev_err(dev, "Failed to enter sleep mode (%d)\n", > ret); > > > - return ret; > > > - } > > > + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); > > > > > > - return 0; > > > + return dsi_ctx.accum_err; > > > > nit: the one caller of r63353_panel_deactivate() doesn't actually > look > > at the error code, so this could be a function that returns "void". > > That was true even before your patch, though. I wouldn't mind a > > followup patch that fixed this. ;-) > > > > > > This is anyway not merged, Maybe better to fix right now instead of a > follow up patch? > > If you can, yeah fix it now ! > On it. Anusha > > > > In any case, the patch looks reasonable to me now. > > > > Reviewed-by: Douglas Anderson <diand...@chromium.org <mailto: > diand...@chromium.org>> > > > > > > Thanks :) > > > > Anusha > > > Thanks, > Neil > > > > > > Happy for someone else to apply it if they want. If not, I'll snooze > > this for ~a week to give others a chance to comment and then plan to > > push to drm-misc-next. > > > > > > > > -Doug > > > >
