On Mon, 10 Mar 2025 22:30:36 +1300 "Ryan Walklin" <r...@testtoast.com> wrote:
Hi Ryan, > On Tue, 25 Feb 2025, at 6:56 AM, Andre Przywara wrote: > > Apologies Andre, I came to review your comments on the TCON series and > realised I had missed responding to this comment before sending v8. No worries about that! > >> + - allwinner,sun50i-h616-de33-mixer-0 > >> > >> reg: > >> - maxItems: 1 > >> + minItems: 1 > >> + maxItems: 3 > > > > What are those three regions? I wonder if we should have reg-names here, > > to fix the order, and to document them on the way? > > This would be the top, display and mixer groups for the DE333, and mixer for > DE3 and earlier. Can certainly add in names for these. Is there any example > elsewhere in the bindings to look at? It's basically the same idea as for clock-names, as used in this very file here (allwinner,sun8i-a83t-de2-mixer.yaml). You can find an explicit example for reg-names in allwinner,sun4i-a10-mbus.yaml, for instance. In the code you would use devm_platform_ioremap_resource_byname() then. Cheers, Andre > >> @@ -61,6 +63,23 @@ properties: > >> required: > >> - port@1 > >> > >> +allOf: > >> + - if: > >> + properties: > >> + compatible: > >> + enum: > >> + - allwinner,sun50i-h616-de33-mixer-0 > >> + > >> + then: > >> + properties: > >> + reg: > >> + maxItems: 3 > > > > Should we override minItems here as well? I guess any driver would need > > all three region to work? > > This seems sensible, as you say it would always be 3 groups for the DE33. > > Regards, > > Ryan
