Re: [PATCH] drm/appletbdrm: Fix ref-counting on dmadev

[Thomas Zimmermann]

Hi

Am 07.03.25 um 10:16 schrieb Aditya Garg:
Hi Thomas
On 7 Mar 2025, at 2:06 PM, Thomas Zimmermann <tzimmerm...@suse.de> wrote:

Remove the put_device() call on dmadev. The driver sets the field
without getting a reference, so it shouldn't put a reference either.
The dmadev field points to the regular USB device for which DRM
maintains a reference internally. Hence dmadev will not become dangling
during the DRM device's lifetime.

Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs")
Cc: Aditya Garg <gargadity...@live.com>
Cc: Aun-Ali Zaidi <ad...@kodeit.net>
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/tiny/appletbdrm.c | 1 -
1 file changed, 1 deletion(-)

Aren’t we doing the same over here:

https://lore.kernel.org/dri-devel/20250307080836.42848-3-tzimmerm...@suse.de/T/#u

Yeah. That series is a full rework of the dma_dev handling for all 
drivers. That won't make it into v6.15. The patch here is a quick fix 
that we can land immediately.

Best regards
Thomas



--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)