Hi Jonathan, kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-xe/drm-xe-next] [also build test WARNING on drm-exynos/exynos-drm-next linus/master v6.14-rc2 next-20250214] [cannot apply to drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jonathan-Cavitt/drm-xe-xe_exec_queue-Add-ID-param-to-exec-queue-struct/20250215-043933 base: https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next patch link: https://lore.kernel.org/r/20250214203757.27895-4-jonathan.cavitt%40intel.com patch subject: [PATCH 3/4] FIXME: drm/xe/xe_drm_client: Add per drm client pagefault info config: alpha-randconfig-r051-20250216 (https://download.01.org/0day-ci/archive/20250216/202502161130.qhitt8dh-...@intel.com/config) compiler: alpha-linux-gcc (GCC) 14.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <l...@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202502161130.qhitt8dh-...@intel.com/ cocci warnings: (new ones prefixed by >>) >> drivers/gpu/drm/xe/xe_gt_pagefault.c:342:3-8: WARNING: NULL check before >> some freeing functions is not needed. vim +342 drivers/gpu/drm/xe/xe_gt_pagefault.c 332 333 static void save_pagefault_to_engine(struct xe_gt *gt, struct pagefault *pf) 334 { 335 struct xe_hw_engine *hwe; 336 337 hwe = xe_gt_hw_engine(gt, pf->engine_class, pf->engine_instance, false); 338 if (hwe) { 339 spin_lock(&hwe->pf.lock); 340 /** The latest pagefault is pf, so remove old pf info from engine */ 341 if (hwe->pf.info) > 342 kfree(hwe->pf.info); 343 hwe->pf.info = kzalloc(sizeof(struct pagefault), GFP_KERNEL); 344 if (hwe->pf.info) 345 memcpy(hwe->pf.info, pf, sizeof(struct pagefault)); 346 spin_unlock(&hwe->pf.lock); 347 } 348 } 349 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
