On Fri, Feb 14, 2025 at 04:28:45PM +0100, Krzysztof Kozlowski wrote: > On 14/02/2025 16:22, Dmitry Baryshkov wrote: > > On Fri, Feb 14, 2025 at 02:17:44PM +0100, Krzysztof Kozlowski wrote: > >> dsi_clk_init(), which gets the clocks, is called only through platform > >> driver probe and its failure is a failure of the probe. Therefore > >> NULL-ifying specific clocks is pointless and redundant - the PTR_ERR > >> value stored there won't be used/dereferenced afterwards. What's more, > >> variant-specific clock init calls like dsi_clk_init_6g_v2() are not > >> doing this cleanup. Dropping redundant code allows later to make this a > >> bit simpler. > >> > >> Reviewed-by: Abhinav Kumar <quic_abhin...@quicinc.com> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org> > >> --- > >> drivers/gpu/drm/msm/dsi/dsi_host.c | 3 --- > >> 1 file changed, 3 deletions(-) > >> > > > > Reviewed-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org> > > > > > Thanks for reviews. Both you and Abhinav reviewed, so I assume this will > be applied by Rob?
I will pick it up once Abhinav posts msm-fixes -- With best wishes Dmitry
