On Fri, 14 Feb 2025, Egor Vorontsov <sdore...@sdore.me> wrote:
> Using le16 instead of u8[2].
> Replaced an error with a printed warning as well.
>
> Suggested-by: Jani Nikula <jani.nik...@linux.intel.com>
> Signed-off-by: Egor Vorontsov <sdore...@sdore.me>
So the two patches should each stand on their own, instead of this one
fixing the issues in the first.
BR,
Jani.
> ---
> drivers/gpu/drm/drm_displayid_internal.h | 22 ++++++++--------
> drivers/gpu/drm/drm_edid.c | 32 ++++++++++++------------
> 2 files changed, 27 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_displayid_internal.h
> b/drivers/gpu/drm/drm_displayid_internal.h
> index 88220c107822..957dd0619f5c 100644
> --- a/drivers/gpu/drm/drm_displayid_internal.h
> +++ b/drivers/gpu/drm/drm_displayid_internal.h
> @@ -115,25 +115,25 @@ struct displayid_tiled_block {
> struct displayid_detailed_timings_1 {
> u8 pixel_clock[3];
> u8 flags;
> - u8 hactive[2];
> - u8 hblank[2];
> - u8 hsync[2];
> - u8 hsw[2];
> - u8 vactive[2];
> - u8 vblank[2];
> - u8 vsync[2];
> - u8 vsw[2];
> + __le16 hactive;
> + __le16 hblank;
> + __le16 hsync;
> + __le16 hsw;
> + __le16 vactive;
> + __le16 vblank;
> + __le16 vsync;
> + __le16 vsw;
> } __packed;
>
> struct displayid_detailed_timing_block {
> struct displayid_block base;
> struct displayid_detailed_timings_1 timings[];
> -};
> +} __packed;
The above belong in patch 2.
>
> struct displayid_formula_timings_9 {
> u8 flags;
> - __be16 hactive;
> - __be16 vactive;
> + __le16 hactive;
> + __le16 vactive;
The above belong in patch 1.
> u8 vrefresh;
> } __packed;
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 9c363df5af9a..54122a12a24f 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -6764,19 +6764,19 @@ static struct drm_display_mode
> *drm_mode_displayid_detailed(struct drm_device *d
> bool type_7)
> {
> struct drm_display_mode *mode;
> - unsigned pixel_clock = (timings->pixel_clock[0] |
> - (timings->pixel_clock[1] << 8) |
> - (timings->pixel_clock[2] << 16)) + 1;
> - unsigned hactive = (timings->hactive[0] | timings->hactive[1] << 8) + 1;
> - unsigned hblank = (timings->hblank[0] | timings->hblank[1] << 8) + 1;
> - unsigned hsync = (timings->hsync[0] | (timings->hsync[1] & 0x7f) << 8)
> + 1;
> - unsigned hsync_width = (timings->hsw[0] | timings->hsw[1] << 8) + 1;
> - unsigned vactive = (timings->vactive[0] | timings->vactive[1] << 8) + 1;
> - unsigned vblank = (timings->vblank[0] | timings->vblank[1] << 8) + 1;
> - unsigned vsync = (timings->vsync[0] | (timings->vsync[1] & 0x7f) << 8)
> + 1;
> - unsigned vsync_width = (timings->vsw[0] | timings->vsw[1] << 8) + 1;
> - bool hsync_positive = (timings->hsync[1] >> 7) & 0x1;
> - bool vsync_positive = (timings->vsync[1] >> 7) & 0x1;
> + unsigned int pixel_clock = (timings->pixel_clock[0] |
> + (timings->pixel_clock[1] << 8) |
> + (timings->pixel_clock[2] << 16)) + 1;
> + unsigned int hactive = le16_to_cpu(timings->hactive) + 1;
> + unsigned int hblank = le16_to_cpu(timings->hblank) + 1;
> + unsigned int hsync = (le16_to_cpu(timings->hsync) & 0x7fff) + 1;
> + unsigned int hsync_width = le16_to_cpu(timings->hsw) + 1;
> + unsigned int vactive = le16_to_cpu(timings->vactive) + 1;
> + unsigned int vblank = le16_to_cpu(timings->vblank) + 1;
> + unsigned int vsync = (le16_to_cpu(timings->vsync) & 0x7fff) + 1;
> + unsigned int vsync_width = le16_to_cpu(timings->vsw) + 1;
> + bool hsync_positive = le16_to_cpu(timings->hsync) & (1 << 15);
> + bool vsync_positive = le16_to_cpu(timings->vsync) & (1 << 15);
The above belong in patch 2.
>
> mode = drm_mode_create(dev);
> if (!mode)
> @@ -6838,8 +6838,8 @@ static struct drm_display_mode
> *drm_mode_displayid_formula(struct drm_device *de
> bool type_10)
> {
> struct drm_display_mode *mode;
> - u16 hactive = be16_to_cpu(timings->hactive) + 1;
> - u16 vactive = be16_to_cpu(timings->vactive) + 1;
> + u16 hactive = le16_to_cpu(timings->hactive) + 1;
> + u16 vactive = le16_to_cpu(timings->vactive) + 1;
> u8 timing_formula = timings->flags & 0x7;
>
> /* TODO: support RB-v2 & RB-v3 */
> @@ -6848,7 +6848,7 @@ static struct drm_display_mode
> *drm_mode_displayid_formula(struct drm_device *de
>
> /* TODO: support video-optimized refresh rate */
> if (timings->flags & (1 << 4))
> - return NULL;
> + drm_dbg_kms(dev, "Fractional vrefresh is not implemented,
> proceeding with non-video-optimized refresh rate");
The above belong in patch 1.
>
> mode = drm_cvt_mode(dev, hactive, vactive, timings->vrefresh + 1,
> timing_formula == 1, false, false);
> if (!mode)
--
Jani Nikula, Intel
