On Thu, Feb 13, 2025 at 03:43:54PM +0100, Maxime Ripard wrote: > The tc358768 bridge driver, if enabling it fails, tries to disable it. > This is pretty uncommon in bridge drivers, and also stands in the way > for further reworks. > > Worse, since pre_enable and enable aren't expected to fail, disable and > post_disable might be called twice: once to handle the failure, and once > to actually disable the bridge. > > Since post_disable uses regulators and clocks, this would lead to enable > count imbalances. > > In order to prevent that imbalance, and to allow further reworks, let's > drop the calls to disable and post_disable, but keep the warning to let > users know about what's going on. > > Signed-off-by: Maxime Ripard <mrip...@kernel.org> > --- > drivers/gpu/drm/bridge/tc358768.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) >
Reviewed-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org> > -- With best wishes Dmitry
