Re: [PATCH V3] drm: xlnx: zynqmp_dpsub: Add NULL check in zynqmp_audio_init

[Tomi Valkeinen]

Hi,

On 11/02/2025 12:20, Charles Han wrote:
devm_kasprintf() calls can return null pointers on failure.
But some return values were not checked in zynqmp_audio_init().
Add NULL check in zynqmp_audio_init(), avoid referencing null
pointers in the subsequent code.

Signed-off-by: Charles Han <hanchunc...@inspur.com>
---
  drivers/gpu/drm/xlnx/zynqmp_dp_audio.c | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp_audio.c 
b/drivers/gpu/drm/xlnx/zynqmp_dp_audio.c
index fa5f0ace6084..f07ff4eb3a6d 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dp_audio.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp_audio.c
@@ -323,12 +323,16 @@ int zynqmp_audio_init(struct zynqmp_dpsub *dpsub)
  
  	audio->dai_name = devm_kasprintf(dev, GFP_KERNEL,
                                         "%s-dai", dev_name(dev));
+       if (!audio->dai_name)
+               return -ENOMEM;
  
  	for (unsigned int i = 0; i < ZYNQMP_NUM_PCMS; ++i) {
                audio->link_names[i] = devm_kasprintf(dev, GFP_KERNEL,
                                                      "%s-dp-%u", 
dev_name(dev), i);
                audio->pcm_names[i] = devm_kasprintf(dev, GFP_KERNEL,
                                                     "%s-pcm-%u", 
dev_name(dev), i);
+               if (!audio->link_names[i] || !audio->pcm_names[i])
+                       return -ENOMEM;
        }
  
  	audio->base = devm_platform_ioremap_resource_byname(pdev, "aud");

Thanks, looks good to me. I'll apply with Laurent's RB, which he gave 
for v1.

 Tomi