From: Bart Van Assche <bvanass...@acm.org>

Instead of attempting the same mutex twice, lock and unlock it.

This bug has been detected by the Clang thread-safety analyzer.

Cc: Sean Anderson <sean.ander...@linux.dev>
Cc: Tomi Valkeinen <tomi.valkei...@ideasonboard.com>
Fixes: 28edaacb821c ("drm: zynqmp_dp: Add debugfs interface for compliance 
testing")
Signed-off-by: Bart Van Assche <bvanass...@acm.org>
Reviewed-by: Sean Anderson <sean.ander...@linux.dev>
Signed-off-by: Sean Anderson <sean.ander...@linux.dev>
---

 drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index 979f6d3239ba..189a08cdc73c 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -2295,7 +2295,7 @@ static int zynqmp_dp_ignore_hpd_set(void *data, u64 val)
 
        mutex_lock(&dp->lock);
        dp->ignore_hpd = val;
-       mutex_lock(&dp->lock);
+       mutex_unlock(&dp->lock);
        return 0;
 }
 
-- 
2.35.1.1320.gc452695387.dirty

Reply via email to