From: Yicong Yang <yangyic...@hisilicon.com>

DP stuffs of hibmc are using DRM DP helpers, select the Kconfig for
dependency. Otherwise with below configuration:
CONFIG_DRM_DISPLAY_HELPER=m
CONFIG_DRM_HISI_HIBMC=y

Below link error is met:
ld: Unexpected GOT/PLT entries detected!
ld: Unexpected run-time procedure linkages detected!
ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.o: in function 
`hibmc_dp_aux_init':
drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c:163: undefined reference to 
`drm_dp_aux_init'
[...]
ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.o: in function 
`hibmc_dp_link_get_adjust_train':
drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.c:129: undefined reference to 
`drm_dp_get_adjust_request_voltage'

Fixes: 54063d86e036 ("drm/hisilicon/hibmc: add dp link moduel in hibmc drivers")
Fixes: 057e77972556 ("drm/hisilicon/hibmc: add dp aux in hibmc drivers")
Cc: Baihan Li <libai...@huawei.com>
Signed-off-by: Yicong Yang <yangyic...@hisilicon.com>
---
 drivers/gpu/drm/hisilicon/hibmc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/hisilicon/hibmc/Kconfig 
b/drivers/gpu/drm/hisilicon/hibmc/Kconfig
index 93b8d32e3be1..249ceac71b19 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/Kconfig
+++ b/drivers/gpu/drm/hisilicon/hibmc/Kconfig
@@ -4,6 +4,7 @@ config DRM_HISI_HIBMC
        depends on DRM && PCI
        depends on MMU
        select DRM_CLIENT_SELECTION
+       select DRM_DISPLAY_HELPER
        select DRM_KMS_HELPER
        select DRM_VRAM_HELPER
        select DRM_TTM
-- 
2.24.0

Reply via email to