On 04/02/2025 15:27, Dmitry Baryshkov wrote:
>>>> struct dsi_pll_7nm *pll_7nm = to_pll_7nm(phy->vco_hw);
>>>> - void __iomem *base = phy->base;
>>>> u32 data = 0x0; /* internal PLL */
>>>>
>>>> DBG("DSI PLL%d", pll_7nm->phy->id);
>>>> @@ -635,7 +634,7 @@ static int dsi_7nm_set_usecase(struct msm_dsi_phy *phy)
>>>> }
>>>>
>>>> /* set PLL src */
>>>> - writel(data << 2, base + REG_DSI_7nm_PHY_CMN_CLK_CFG1);
>>>> + dsi_pll_cmn_clk_cfg1_update(pll_7nm, GENMASK(3, 2), data << 2);
>>>
>>> The mask is not defined, still.
>>
>> Why would it be? That's old/existing code. Commit is doing only one
>> thing - fixing something. Not introducing some masks or defines and
>> changing hard-coded values into defines.
>
> GENMASK(3, 2) needs to be defined in the XML file. It was not there
> beforehand, you have just introduced it.
You are right.
Best regards,
Krzysztof
