On 14/01/2025 17:34, Adrián Larumbe wrote:
This is motivated by the desire of some drivers (eg. Panthor) to print the
size of internal memory regions with a prefix that reflects the driver
name, as suggested in the previous documentation commit.

That means adding a new argument to print_size and making it available for
DRM users.

Signed-off-by: Adrián Larumbe <adrian.laru...@collabora.com>
Cc: Tvrtko Ursulin <tursu...@ursulin.net>
---
  drivers/gpu/drm/drm_file.c | 27 +++++++++++++++++++--------
  include/drm/drm_file.h     |  5 +++++
  2 files changed, 24 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index cb5f22f5bbb6..f584abcd13cb 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -830,8 +830,12 @@ void drm_send_event(struct drm_device *dev, struct 
drm_pending_event *e)
  }
  EXPORT_SYMBOL(drm_send_event);
-static void print_size(struct drm_printer *p, const char *stat,
-                      const char *region, u64 sz)
+
+void drm_fdinfo_print_size(struct drm_printer *p,
+                          const char *prefix,
+                          const char *stat,
+                          const char *region,
+                          u64 sz)
  {
        const char *units[] = {"", " KiB", " MiB"};
        unsigned u;
@@ -842,8 +846,10 @@ static void print_size(struct drm_printer *p, const char 
*stat,
                sz = div_u64(sz, SZ_1K);
        }
- drm_printf(p, "drm-%s-%s:\t%llu%s\n", stat, region, sz, units[u]);
+       drm_printf(p, "%s-%s-%s:\t%llu%s\n",
+                  prefix, stat, region, sz, units[u]);
  }
+EXPORT_SYMBOL(drm_fdinfo_print_size);
/**
   * drm_print_memory_stats - A helper to print memory stats
@@ -858,15 +864,20 @@ void drm_print_memory_stats(struct drm_printer *p,
                            enum drm_gem_object_status supported_status,
                            const char *region)
  {
-       print_size(p, "total", region, stats->private + stats->shared);
-       print_size(p, "shared", region, stats->shared);
-       print_size(p, "active", region, stats->active);
+       const char *prefix = "drm";
+
+       drm_fdinfo_print_size(p, prefix, "total", region,
+                             stats->private + stats->shared);
+       drm_fdinfo_print_size(p, prefix, "shared", region, stats->shared);
+       drm_fdinfo_print_size(p, prefix, "active", region, stats->active);
if (supported_status & DRM_GEM_OBJECT_RESIDENT)
-               print_size(p, "resident", region, stats->resident);
+               drm_fdinfo_print_size(p, prefix, "resident", region,
+                                     stats->resident);
if (supported_status & DRM_GEM_OBJECT_PURGEABLE)
-               print_size(p, "purgeable", region, stats->purgeable);
+               drm_fdinfo_print_size(p, prefix, "purgeable", region,
+                                     stats->purgeable);
  }
  EXPORT_SYMBOL(drm_print_memory_stats);
diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
index f0ef32e9fa5e..001ae553e8c3 100644
--- a/include/drm/drm_file.h
+++ b/include/drm/drm_file.h
@@ -494,6 +494,11 @@ struct drm_memory_stats {
enum drm_gem_object_status; +void drm_fdinfo_print_size(struct drm_printer *p,
+                                 const char *prefix,
+                                 const char *stat,
+                                 const char *region,
+                                 u64 sz);
  void drm_print_memory_stats(struct drm_printer *p,
                            const struct drm_memory_stats *stats,
                            enum drm_gem_object_status supported_status,

If I can get away with a sneaky:

Reviewed-by: Tvrtko Ursulin <tvrtko.ursu...@igalia.com>

Regards,

Tvrtko

Reply via email to