Two nits below, regardless:

Reviewed-by: Simon Ser <cont...@emersion.fr>

> +static int drm_colorop_create_data_prop(struct drm_device *dev, struct 
> drm_colorop *colorop)
> +{
> +     struct drm_property *prop;
> +
> +     /* data */
> +     prop = drm_property_create(dev, DRM_MODE_PROP_ATOMIC | 
> DRM_MODE_PROP_BLOB,
> +                                     "DATA", 0);
> +     if (!prop)
> +             return -ENOMEM;
> +
> +     colorop->data_property = prop;
> +     drm_object_attach_property(&colorop->base,
> +                                     colorop->data_property,
> +                                     0);

Nit: indentation is off here, also applies to other spots in this patch

> @@ -288,6 +329,7 @@ void drm_colorop_reset(struct drm_colorop *colorop)
>  
>  static const char * const colorop_type_name[] = {
>       [DRM_COLOROP_1D_CURVE] = "1D Curve",
> +     [DRM_COLOROP_CTM_3X4] = "3x4 Matrix"

Nit: missing trailing comma (these reduce diff churn)

Reply via email to