Re: [PATCH v3 04/15] drm/msm/dpu: decide right side per last bit

[Jessica Zhang]

On 12/19/2024 2:09 PM, Dmitry Baryshkov wrote:
On Thu, Dec 19, 2024 at 03:49:22PM +0800, Jun Nie wrote:
decide right side of a pair per last bit, in case of multiple
mixer pairs.

Proper English sentences, please. Also describe why, not what.

Hi Jun,

Can we also add a note in the commit message on why the last bit check 
works?

Thanks,

Jessica Zhang



Signed-off-by: Jun Nie <jun....@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org>
---
  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c 
b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index 7191b1a6d41b3..41c9d3e3e3c7c 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
@@ -369,11 +369,10 @@ static void _dpu_crtc_setup_blend_cfg(struct 
dpu_crtc_mixer *mixer,
  static void _dpu_crtc_program_lm_output_roi(struct drm_crtc *crtc)
  {
        struct dpu_crtc_state *crtc_state;
-       int lm_idx, lm_horiz_position;
+       int lm_idx;
  
  	crtc_state = to_dpu_crtc_state(crtc->state);
  
-	lm_horiz_position = 0;
        for (lm_idx = 0; lm_idx < crtc_state->num_mixers; lm_idx++) {
                const struct drm_rect *lm_roi = &crtc_state->lm_bounds[lm_idx];
                struct dpu_hw_mixer *hw_lm = crtc_state->mixers[lm_idx].hw_lm;
@@ -384,7 +383,7 @@ static void _dpu_crtc_program_lm_output_roi(struct drm_crtc 
*crtc)
  
  		cfg.out_width = drm_rect_width(lm_roi);
                cfg.out_height = drm_rect_height(lm_roi);
-               cfg.right_mixer = lm_horiz_position++;
+               cfg.right_mixer = lm_idx & 0x1;
                cfg.flags = 0;
                hw_lm->ops.setup_mixer_out(hw_lm, &cfg);
        }

--
2.34.1


--
With best wishes
Dmitry