On Wed, 11 Dec 2024 08:08:09 +0800
Zijun Hu <zijun...@icloud.com> wrote:

> From: Zijun Hu <quic_zij...@quicinc.com>
> 
> static of_slim_match_dev() has same function as API device_match_of_node().
> 
> Remove the former and use the later instead.
> 
> Signed-off-by: Zijun Hu <quic_zij...@quicinc.com>
Nice tidy up given the current code is dance up and down containing structure 
to exactly
the same device it started with.

Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com>
> ---
>  drivers/slimbus/core.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
> index 
> ab927fd077cb4fe1e29c004269fe52b2896c302f..005fa2ef100f526df5603d212b6334c06a366c94
>  100644
> --- a/drivers/slimbus/core.c
> +++ b/drivers/slimbus/core.c
> @@ -385,21 +385,13 @@ struct slim_device *slim_get_device(struct 
> slim_controller *ctrl,
>  }
>  EXPORT_SYMBOL_GPL(slim_get_device);
>  
> -static int of_slim_match_dev(struct device *dev, const void *data)
> -{
> -     const struct device_node *np = data;
> -     struct slim_device *sbdev = to_slim_device(dev);
> -
> -     return (sbdev->dev.of_node == np);
> -}
> -
>  static struct slim_device *of_find_slim_device(struct slim_controller *ctrl,
>                                              struct device_node *np)
>  {
>       struct slim_device *sbdev;
>       struct device *dev;
>  
> -     dev = device_find_child(ctrl->dev, np, of_slim_match_dev);
> +     dev = device_find_child(ctrl->dev, np, device_match_of_node);
>       if (dev) {
>               sbdev = to_slim_device(dev);
>               return sbdev;
> 

Reply via email to