On Tue, Dec 10, 2024 at 02:53:56PM +0800, Fange Zhang wrote:
> From: Li Liu <quic_ll...@quicinc.com>
> 
> Add definitions for the display hardware used on the Qualcomm SM6150
> platform.
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org>
> Signed-off-by: Li Liu <quic_ll...@quicinc.com>
> Signed-off-by: Fange Zhang <quic_fan...@quicinc.com>
> ---
>  .../gpu/drm/msm/disp/dpu1/catalog/dpu_5_3_sm6150.h | 254 
> +++++++++++++++++++++
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c     |   1 +
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h     |   1 +
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c            |   1 +
>  4 files changed, 257 insertions(+)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_3_sm6150.h 
> b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_3_sm6150.h
> new file mode 100644
> index 
> 0000000000000000000000000000000000000000..621a2140f675fa28b3a7fcd8573e59b306cd6832
> --- /dev/null
> +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_3_sm6150.h

[...]

> +
> +const struct dpu_mdss_cfg dpu_sm6150_cfg = {
> +     .mdss_ver = &sm6150_mdss_ver,
> +     .caps = &sm6150_dpu_caps,
> +     .mdp = &sm6150_mdp,
> +     .ctl_count = ARRAY_SIZE(sm6150_ctl),
> +     .ctl = sm6150_ctl,
> +     .sspp_count = ARRAY_SIZE(sm6150_sspp),
> +     .sspp = sm6150_sspp,
> +     .mixer_count = ARRAY_SIZE(sm6150_lm),
> +     .mixer = sm6150_lm,
> +     .dspp_count = ARRAY_SIZE(sm6150_dspp),
> +     .dspp = sm6150_dspp,
> +     .pingpong_count = ARRAY_SIZE(sm6150_pp),
> +     .pingpong = sm6150_pp,
> +     .intf_count = ARRAY_SIZE(sm6150_intf),
> +     .intf = sm6150_intf,
> +     .vbif_count = ARRAY_SIZE(sdm845_vbif),
> +     .vbif = sdm845_vbif,
> +     .perf = &sm6150_perf_data,

I noticed that the catalog entry doesn't provide writeback configuration
although the vendor DTSi specified that there is WB_2 on this platform.
Please send a followup patch enabling writeback on this platform.

> +};
> +
> +#endif

-- 
With best wishes
Dmitry

Reply via email to